kayomn
3 Followers · 5 Following
Repositories
13
 Projects Packages Public Activity Starred Repositories
1
kayomn commented on issue kayomn/ona#42 2023-11-05 16:54:56 +01:00
Constant Folding for Let Variables in Ona Script

Removing this as a milestone for the scripting MVP.

kayomn commented on issue kayomn/ona#41 2023-11-05 16:53:31 +01:00
Ona Script Closures

Resolved as part of #44.

kayomn closed issue kayomn/ona#41 2023-11-05 16:53:31 +01:00
Ona Script Closures
kayomn merged pull request kayomn/ona#44 2023-11-05 16:52:52 +01:00
Closures, Higher-Order Functions, and Everything in Between
kayomn pushed to main at kayomn/ona 2023-11-05 16:52:52 +01:00
03a8abc5dd Merge pull request 'Closures, Higher-Order Functions, and Everything in Between' (#44) from kym-captures into main
816051f066 Amend code review
c86173d759 Fix bugs with n+1-nested closures
88ff2a64b6 Make arguments read-only
880761a722 Implement closures
Compare 5 commits »
kayomn deleted branch kym-captures from kayomn/ona 2023-11-05 16:52:52 +01:00
kayomn pushed to kym-captures at kayomn/ona 2023-11-05 16:51:33 +01:00
816051f066 Amend code review
kayomn commented on pull request kayomn/ona#44 2023-11-05 16:32:13 +01:00
Closures, Higher-Order Functions, and Everything in Between

Actually this is out of scope and really a non-issue right now.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Why unreachable?

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Why unreachable?

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

What is this for?

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

May be worth replacing with VM managed Buffer object rather than raw Zig array.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

All these raw illegal state calls may be better as a VM-managed assert function.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Debugging code wants removing or moving somewhere else that is easier to switch on or off.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Why rename?

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

This shouldn't be capable of crashing the process - needs better handling.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Shorten to use root.report_declare_error.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Shorten to use root.report_declare_error.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

Should ideally be marked pub as is used on public interface for struct.

kayomn commented on pull request kayomn/ona#44 2023-11-05 15:51:51 +01:00
Closures, Higher-Order Functions, and Everything in Between

TODO functions should be unreachable and have a comment.