kayomn pushed to main at kayomn/esp-modman 2022-12-06 10:33:53 +01:00
c55ce0562c Add clean function to manager
kayomn pushed to main at kayomn/esp-modman 2022-12-05 14:14:04 +01:00
56d80c4883 Parial work on clean and deploy
kayomn pushed to main at kayomn/esp-modman 2022-12-03 19:27:57 +01:00
3b92ee1421 Decouple extractors from manager logic
kayomn pushed to main at kayomn/esp-modman 2022-12-03 18:56:40 +01:00
21b999e6eb Implement most unimplemented functions
kayomn created branch main in kayomn/esp-modman 2022-12-02 02:24:37 +01:00
kayomn pushed to main at kayomn/esp-modman 2022-12-02 02:24:37 +01:00
e44f196236 Initial commit
kayomn created repository kayomn/esp-modman 2022-12-02 01:52:44 +01:00
kayomn commented on pull request kayomn/ona#4 2022-11-08 10:47:23 +01:00
Application Context Implementation

Two remaining tasks before this can be merged in:

  • Compiler bug causing the build error needs working around - either by patching the error or upgrading Zig to 0.10.0.

  • The amount…

kayomn pushed to event-loop-dev at kayomn/ona 2022-11-08 00:51:49 +01:00
47a997b0ec Implement loading of Oar archive entry-backed files
kayomn pushed to event-loop-dev at kayomn/ona 2022-11-04 11:38:42 +01:00
4f0224a029 Fix documentation / tidy up code
kayomn commented on pull request kayomn/ona#4 2022-11-03 18:09:09 +01:00
Application Context Implementation

On further thought, having the comment here to begin with only adds confusion.

While slices don't have as trivial of a memory layout as other pointer types, they're still language primitives…

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Comment needs clarify as it appears slightly misleading / ambiguous in its current wording.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Worth mentioning that it performs linear time, making it O(n) time complexity?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Worth mentioning that this uses linear search?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Warrants TODO comment mentioning that this stdlib dependency should be removed in future.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Reallocation could benefit from the same kind of last-alloc check optimization as deallocation.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Seeing as FixedStack does not depend on any kind of dynamic allocation directly, does it make sense to make PushError a direct alias of io.MakeError?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Since this function is only ever used to check if the load factor is at / beyond its maximum, would it make more sense to replace it with isMaxLoad(Self) bool or something like that which meets the requirements of it uses more precisely?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Comment typo: if any key instead of if an key.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.