133 contributions in the last 12 months
JanFebMarAprMayJunJulAugSepOctNovDecMonWedFri
Less
More
kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Worth mentioning that this uses linear search?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Warrants TODO comment mentioning that this stdlib dependency should be removed in future.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Reallocation could benefit from the same kind of last-alloc check optimization as deallocation.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Seeing as FixedStack does not depend on any kind of dynamic allocation directly, does it make sense to make PushError a direct alias of io.MakeError?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Since this function is only ever used to check if the load factor is at / beyond its maximum, would it make more sense to replace it with isMaxLoad(Self) bool or something like that which meets the requirements of it uses more precisely?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Comment typo: if any key instead of if an key.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Also, should this be public?

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Missing documentation comment.

kayomn commented on pull request kayomn/ona#4 2022-11-03 18:06:02 +01:00
Application Context Implementation

Unused and out of date.