kayomn
3 Followers · 5 Following
Repositories
13
 Projects Packages Public Activity Starred Repositories
1
kayomn commented on issue kayomn/ona#26 2023-07-22 15:56:04 +02:00
Ona Script Comments

Comments are actually already meant to be supported in the tokenizer, however a bug was preventing the branch that handles them from ever getting properly invoked.

This led to only the #…

kayomn created pull request kayomn/ona#29 2023-07-22 15:48:11 +02:00
WIP: Improve Syntax Error Messages and Add Comments
kayomn created branch kym-script-comments in kayomn/ona 2023-07-22 15:44:37 +02:00
kayomn pushed to kym-script-comments at kayomn/ona 2023-07-22 15:44:37 +02:00
b311c73c43 Add syntax error reporting
kayomn pushed to main at kayomn/ona 2023-07-22 15:03:23 +02:00
5d06e61564 Merge pull request 'Native "Syscall" Interface for Kym' (#21) from kym-native-function into main
a320a795bc Amend code review issues
8137f2b474 Fix memory leaks
7b4b827dc2 Refactor Kym runtime API
1ea115b277 Replace globals with native call interface
Compare 7 commits »
kayomn deleted branch kym-native-function from kayomn/ona 2023-07-22 15:03:23 +02:00
kayomn merged pull request kayomn/ona#21 2023-07-22 15:03:22 +02:00
Native "Syscall" Interface for Kym
kayomn closed issue kayomn/ona#20 2023-07-22 15:03:22 +02:00
Kym Native Function Interface
kayomn pushed to kym-native-function at kayomn/ona 2023-07-22 14:57:47 +02:00
a320a795bc Amend code review issues
kayomn opened issue kayomn/ona#28 2023-07-22 13:58:18 +02:00
Unnecessary Copying in Kym Runtime Heap
kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Inaccurate log message.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Error union is unused.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Unused function.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Can be simplified to single expression

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

A lot of duplication with @typeInfo(usize).Int and getting min / max limits of int types in general. These could be reduced into a constants declared in function body to reduce repetition.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Resolve TODOs in the function body.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Potentially (but very unlikely to ever trigger) unsafe length cast.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Potentially (but very unlikely to ever trigger) unsafe length cast.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Potentially (but very unlikely to ever trigger) unsafe length cast.

kayomn commented on pull request kayomn/ona#21 2023-07-22 13:56:01 +02:00
Native "Syscall" Interface for Kym

Does this operation "get" like the name suggests (acquiring a reference) or is it an immutable view like the current implementation suggests?