renderer-mvp/asset-pipeline #53

Merged
kayomn merged 6 commits from renderer-mvp/asset-pipeline into main 2024-06-23 04:37:40 +02:00
Owner
No description provided.
kayomn added this to the 1.0 milestone 2024-06-23 04:05:07 +02:00
kayomn added the
bug
label 2024-06-23 04:05:08 +02:00
kayomn self-assigned this 2024-06-23 04:05:08 +02:00
kayomn added 4 commits 2024-06-23 04:05:09 +02:00
kayomn reviewed 2024-06-23 04:28:21 +02:00
@ -7,3 +7,3 @@
const std = @import("std");
pub const Byte = u8;
pub const Writable = struct {
Author
Owner

Unused addition.

Unused addition.
kayomn marked this conversation as resolved
@ -54,3 +54,3 @@
std.debug.assert(try self.table.emplace(value_id, .{
.ptr = allocated_resource,
.ptr = @ptrCast(allocated_resource),
Author
Owner

Bad idea to forcibly convert non-trivial downcasts like **opaque actually

Bad idea to forcibly convert non-trivial downcasts like `**opaque` actually
kayomn marked this conversation as resolved
src/ona/gfx.zig Outdated
@ -15,0 +26,4 @@
};
};
pub fn open_file(self: *Assets, path: []const u8) (std.mem.Allocator.Error || Format.Error)!Handle {
Author
Owner

Wants to accept the desired storage source as an argument for loading resources from non-bundled locations like user storage or caller-defined storage implementations.

Wants to accept the desired storage source as an argument for loading resources from non-bundled locations like user storage or caller-defined storage implementations.
kayomn marked this conversation as resolved
kayomn added 1 commit 2024-06-23 04:32:01 +02:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
bfa3efbb51
PR tidy up
kayomn added 1 commit 2024-06-23 04:35:38 +02:00
continuous-integration/drone/pr Build is passing Details
continuous-integration/drone/push Build is passing Details
f0cc66edfa
Fix compilation errors
kayomn changed title from WIP: renderer-mvp/asset-pipeline to renderer-mvp/asset-pipeline 2024-06-23 04:35:48 +02:00
kayomn merged commit a4280c8fe8 into main 2024-06-23 04:37:40 +02:00
kayomn deleted branch renderer-mvp/asset-pipeline 2024-06-23 04:37:40 +02:00
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kayomn/ona#53
No description provided.