kayomn/ona
1
0
Fork 0
Code Issues 8 Pull Requests Projects 4 Releases Activity

renderer-mvp/asset-pipeline #53

Merged
kayomn merged 6 commits from renderer-mvp/asset-pipeline into main 2024-06-23 04:37:40 +02:00
Conversation 1 Commits 6 Files Changed 20 +1229 -1095
kayomn commented 2024-06-23 04:05:07 +02:00
Owner
Copy Link
No description provided.
kayomn added this to the 1.0 milestone 2024-06-23 04:05:07 +02:00
kayomn added the
bug
 label 2024-06-23 04:05:08 +02:00
kayomn self-assigned this 2024-06-23 04:05:08 +02:00
kayomn added 4 commits 2024-06-23 04:05:09 +02:00
Update to Zig 0.13.0
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
9cfabae931
kayomn reviewed 2024-06-23 04:28:21 +02:00
src/coral/io.zig
@ -7,3 +7,3 @@
const std = @import("std");
pub const Byte = u8;
pub const Writable = struct {
kayomn commented 2024-06-23 04:25:33 +02:00
Author
Owner
Copy Link

Unused addition.

Unused addition.
kayomn marked this conversation as resolved
src/coral/resource.zig Outdated
@ -54,3 +54,3 @@
std.debug.assert(try self.table.emplace(value_id, .{
.ptr = allocated_resource,
.ptr = @ptrCast(allocated_resource),
kayomn commented 2024-06-23 04:26:30 +02:00
Author
Owner
Copy Link

Bad idea to forcibly convert non-trivial downcasts like **opaque actually

Bad idea to forcibly convert non-trivial downcasts like `**opaque` actually
kayomn marked this conversation as resolved
src/ona/gfx.zig Outdated
@ -15,0 +26,4 @@
};
};
pub fn open_file(self: *Assets, path: []const u8) (std.mem.Allocator.Error || Format.Error)!Handle {
kayomn commented 2024-06-23 04:27:59 +02:00
Author
Owner
Copy Link

Wants to accept the desired storage source as an argument for loading resources from non-bundled locations like user storage or caller-defined storage implementations.

Wants to accept the desired storage source as an argument for loading resources from non-bundled locations like user storage or caller-defined storage implementations.
kayomn marked this conversation as resolved
kayomn added 1 commit 2024-06-23 04:32:01 +02:00
PR tidy up
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
bfa3efbb51
kayomn added 1 commit 2024-06-23 04:35:38 +02:00
Fix compilation errors
All checks were successful
continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details
f0cc66edfa
kayomn changed title from WIP: renderer-mvp/asset-pipeline to renderer-mvp/asset-pipeline 2024-06-23 04:35:48 +02:00
kayomn merged commit a4280c8fe8 into main 2024-06-23 04:37:40 +02:00
kayomn deleted branch renderer-mvp/asset-pipeline 2024-06-23 04:37:40 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
documentation
Related to the written information of the project
duplicate
This issue or pull request already exists
help wanted
Need some help
invalid
Something is wrong
performance
question
More information is needed
tools
Related to the tools used to build the project
No Label
bug
Milestone
No items
No Milestone 1.0
Projects
Clear projects
No project
Assignees
Clear assignees
kayomn
No Assignees kayomn
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kayomn/ona#53
No description provided.
Delete Branch "renderer-mvp/asset-pipeline"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?