kayomn
/
ona
1
0
Fork 0
Code Issues 8 Pull Requests Projects 4 Releases Activity

Improve Syntax Error Messages and Fix Comments #29

Merged
kayomn merged 4 commits from kym-script-comments into main 2023-07-22 16:08:04 +02:00
Conversation 0 Commits 4 Files Changed 7 +135 -111
kayomn commented 2023-07-22 15:48:10 +02:00
Owner
Copy Link

Adds / fixes syntax error messages and closes #26.

Adds / fixes syntax error messages and closes #26.
kayomn added this to the (deleted) milestone 2023-07-22 15:48:10 +02:00
kayomn added the
bug
 label 2023-07-22 15:48:10 +02:00
kayomn self-assigned this 2023-07-22 15:48:11 +02:00
kayomn added 1 commit 2023-07-22 15:48:11 +02:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
b311c73c43 Add syntax error reporting
kayomn changed title from WIP: Improve Syntax Error Messages and Add Comments to WIP: Improve Syntax Error Messages and Fix Comments 2023-07-22 15:56:24 +02:00
kayomn added 2 commits 2023-07-22 15:57:02 +02:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
62a318e69b Fix comments not being properly tokenized
kayomn reviewed 2023-07-22 15:59:16 +02:00
source/ona/kym.zig Outdated
@ -208,7 +208,7 @@ pub const RuntimeEnv = struct {
var tokenizer = tokens.Tokenizer{.source = data};
kayomn commented 2023-07-22 15:58:40 +02:00
Author
Owner
Copy Link

There's no benefit to handling the tokenizer as external state being passed to the AST. It may as well just be part of the AST state internally.

There's no benefit to handling the tokenizer as external state being passed to the AST. It may as well just be part of the AST state internally.
kayomn marked this conversation as resolved
kayomn added 1 commit 2023-07-22 16:06:45 +02:00
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
51732a9bf5 Change KYM tokenizer to be internal AST.
kayomn changed title from WIP: Improve Syntax Error Messages and Fix Comments to Improve Syntax Error Messages and Fix Comments 2023-07-22 16:07:52 +02:00
kayomn merged commit e71048e83d into main 2023-07-22 16:08:03 +02:00
kayomn deleted branch kym-script-comments 2023-07-22 16:08:05 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
documentation

Related to the written information of the project

  
duplicate

This issue or pull request already exists

  
help wanted

Need some help

  
invalid

Something is wrong

  
performance

   
question

More information is needed

  
tools

Related to the tools used to build the project

No Label
bug
documentation
duplicate
help wanted
invalid
performance
question
tools
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
kayomn
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: kayomn/ona#29
No description provided.
Delete Branch "kym-script-comments"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?