Merge branch 'clang-tidy' into 'master'

Clang Tidy

See merge request basalt/basalt!46
This commit is contained in:
Vladyslav Usenko 2021-05-08 16:03:15 +00:00
commit 709a1b4a91
5 changed files with 85 additions and 5 deletions

80
.clang-tidy Normal file
View File

@ -0,0 +1,80 @@
Checks: 'readability-*, -readability-magic-numbers, -readability-function-cognitive-complexity, -readability-else-after-return, -readability-redundant-access-specifiers, performance-*, modernize-*, -modernize-use-trailing-return-type, -modernize-avoid-c-arrays, -modernize-use-nodiscard, -modernize-use-auto, -modernize-pass-by-value, misc-assert-side-effect, -clang-analyzer-osx.*, -clang-analyzer-cplusplus.Move, -clang-analyzer-core.uninitialized.UndefReturn, -clang-analyzer-optin.portability.UnixAPI, -clang-analyzer-unix.Malloc'
WarningsAsErrors: '*'
HeaderFilterRegex: '.*/thirdparty/basalt-headers/include/basalt/*'
CheckOptions:
# Classes, structs, ...
- key: readability-identifier-naming.NamespaceCase
value: lower_case
- key: readability-identifier-naming.ClassCase
value: CamelCase
- key: readability-identifier-naming.StructCase
value: CamelCase
- key: readability-identifier-naming.EnumCase
value: CamelCase
- key: readability-identifier-naming.UnionCase
value: CamelCase
- key: readability-identifier-naming.TypedefCase
value: CamelCase
# Variables, member variables, ...
- key: readability-identifier-naming.ParameterCase
value: lower_case
- key: readability-identifier-naming.ParameterIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.VariableCase
value: lower_case
- key: readability-identifier-naming.VariableIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.MemberCase
value: lower_case
- key: readability-identifier-naming.PublicMemberCase
value: lower_case
- key: readability-identifier-naming.PublicMemberIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.ProtectedMemberCase
value: lower_case
- key: readability-identifier-naming.ProtectedMemberSuffix
value: _
- key: readability-identifier-naming.ProtectedMemberIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.PrivateMemberCase
value: lower_case
- key: readability-identifier-naming.PrivateMemberIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.PrivateMemberSuffix
value: _
# Functions, methods, ...
- key: readability-identifier-naming.FunctionCase
value: camelBack
- key: readability-identifier-naming.MethodCase
value: camelBack
# Constants
- key: readability-identifier-naming.ConstantPrefix
value: ''
- key: readability-identifier-naming.ConstantCase
value: UPPER_CASE
- key: readability-identifier-naming.ConstantMemberPrefix
value: ''
- key: readability-identifier-naming.ConstantMemberCase
value: lower_case
- key: readability-identifier-naming.ConstantMemberIgnoredRegexp
value: '^.*_$'
- key: readability-identifier-naming.ConstantParameterPrefix
value: ''
- key: readability-identifier-naming.ConstantParameterCase
value: lower_case
- key: readability-identifier-naming.ConstantParameterIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.LocalConstantParameterPrefix
value: ''
- key: readability-identifier-naming.LocalConstantCase
value: lower_case
- key: readability-identifier-naming.LocalConstantIgnoredRegexp
value: 'Q[12]?_.*|[A-Z]|[JH]_.*|[TR]_[a-z]+_[a-z]+.*'
- key: readability-identifier-naming.ConstexprVariablePrefix
value: ''
- key: readability-identifier-naming.ConstexprVariableCase
value: UPPER_CASE

View File

@ -67,11 +67,11 @@ VignetteEstimator::VignetteEstimator(
for (size_t i = 0; i < vio_dataset->get_num_cams(); i++) { for (size_t i = 0; i < vio_dataset->get_num_cams(); i++) {
while (vign_param[i].maxTimeNs() < while (vign_param[i].maxTimeNs() <
int64_t(vign_size) * int64_t(1e9 * 0.7)) { int64_t(vign_size) * int64_t(1e9 * 0.7)) {
vign_param[i].knots_push_back(Eigen::Matrix<double, 1, 1>(1)); vign_param[i].knotsPushBack(Eigen::Matrix<double, 1, 1>(1));
} }
while (vign_param[i].maxTimeNs() < int64_t(vign_size) * int64_t(1e9)) { while (vign_param[i].maxTimeNs() < int64_t(vign_size) * int64_t(1e9)) {
vign_param[i].knots_push_back(Eigen::Matrix<double, 1, 1>(0.01)); vign_param[i].knotsPushBack(Eigen::Matrix<double, 1, 1>(0.01));
} }
} }

View File

@ -293,7 +293,7 @@ void load_data(const std::string& calib_path, const std::string& cache_path) {
gt_spline.reset(new basalt::Se3Spline<5>(t_ns)); gt_spline.reset(new basalt::Se3Spline<5>(t_ns));
for (size_t i = 0; i < knots.size(); i++) { for (size_t i = 0; i < knots.size(); i++) {
gt_spline->knots_push_back(knots[i]); gt_spline->knotsPushBack(knots[i]);
} }
is.close(); is.close();

View File

@ -536,7 +536,7 @@ void gen_data() {
gt_spline = basalt::Se3Spline<5>(t_ns); gt_spline = basalt::Se3Spline<5>(t_ns);
for (size_t i = 0; i < knots.size(); i++) { for (size_t i = 0; i < knots.size(); i++) {
gt_spline.knots_push_back(knots[i]); gt_spline.knotsPushBack(knots[i]);
} }
archive(cereal::make_nvp("noisy_accel", noisy_accel)); archive(cereal::make_nvp("noisy_accel", noisy_accel));

@ -1 +1 @@
Subproject commit 813ce2d7a6854f25561b8b3810b0bf355658a161 Subproject commit 70a3926a524e47421c63c6cadcd59293ccd7d14b