coral::callable Over-Usage #7

New Issue

kayomn · 2023-02-23T04:44:18+01:00

kayomn commented

2023-02-23 04:44:18 +01:00

The coral::callable type erasing container is used a lot throughout the various first-party libraries of the code base. However, the ownership semantics that is employed within make it expensive to both create and call compared to the scenarios it is used it.

The most blatant example of this is as a function argument that is executed within the frame of the function it is passed to. Because the object will never live beyond the scope of its use, it shouldn't need to take ownership of the lambda memory through copying. Simply referencing the value has some simple performance wins across the board.

Memory layout drops from 32 to 16 bytes on x86-64 and 8 bytes under 32-bit compilation.
No more redundant copying of bits before they are executed.
Reduced copying and less L-values will give the compiler an easier time optimizing out the pointer indirections.

The `coral::callable` type erasing container is used a lot throughout the various first-party libraries of the code base. However, the ownership semantics that is employed within make it expensive to both create and call compared to the scenarios it is used it. The most blatant example of this is as a function argument that is executed within the frame of the function it is passed to. Because the object will never live beyond the scope of its use, it shouldn't need to take ownership of the lambda memory through copying. Simply referencing the value has some simple performance wins across the board. 1. Memory layout drops from 32 to 16 bytes on x86-64 and 8 bytes under 32-bit compilation. 2. No more redundant copying of bits before they are executed. 3. Reduced copying and less L-values will give the compiler an easier time optimizing out the pointer indirections.

kayomn added the

performance

label 2023-02-23 04:55:34 +01:00

kayomn referenced a pull request that will close this issue

2023-02-23 16:11:17 +01:00

Replace `coral::callable` with `coral::closure` #9

kayomn closed this issue

2023-02-23 16:12:30 +01:00

Sign in to join this conversation.